GCC Code Coverage Report

Directory: cvmfs/
File: cvmfs/upload_facility.cc
Date: 2026-10-04 02:40:33
Exec Total Coverage
Lines: 72 88 81.8%
Branches: 24 51 47.1%
Line Branch Exec Source
1 /**
2 * This file is part of the CernVM File System.
3 */
4
5 #include "upload_facility.h"
6
7 #include <cassert>
8
9 #include "upload_gateway.h"
10 #include "upload_local.h"
11 #include "upload_s3.h"
12 #include "util/exception.h"
13
14 namespace upload {
15
16 atomic_int64 UploadStreamHandle::g_upload_stream_tag = 0;
17
18 5169455 AbstractUploader::UploadJob::UploadJob(UploadStreamHandle *handle,
19 UploadBuffer buffer,
20 5169455 const CallbackTN *callback)
21 5169455 : type(Upload)
22 5169455 , stream_handle(handle)
23 5169455 , tag_(handle->tag)
24 5169455 , buffer(buffer)
25 5169455 , callback(callback) { }
26
27 3008369 AbstractUploader::UploadJob::UploadJob(UploadStreamHandle *handle,
28 3008369 const shash::Any &content_hash)
29 3008369 : type(Commit)
30 3008369 , stream_handle(handle)
31 3008369 , tag_(handle->tag)
32 3008369 , buffer()
33 3008357 , callback(NULL)
34 3008357 , content_hash(content_hash) { }
35
36 1499 void AbstractUploader::RegisterPlugins() {
37 1499 RegisterPlugin<LocalUploader>();
38 1499 RegisterPlugin<S3Uploader>();
39 1499 RegisterPlugin<GatewayUploader>();
40 1499 }
41
42 2240 AbstractUploader::AbstractUploader(const SpoolerDefinition &spooler_definition)
43 2240 : spooler_definition_(spooler_definition)
44 2240 , num_upload_tasks_(spooler_definition.num_upload_tasks)
45
2/4
✓ Branch 3 taken 2240 times.
✗ Branch 4 not taken.
✓ Branch 6 taken 2240 times.
✗ Branch 7 not taken.
 2240 , jobs_in_flight_(spooler_definition.number_of_concurrent_uploads) { }
46
47
48 2240 bool AbstractUploader::Initialize() {
49
2/2
✓ Branch 1 taken 2422 times.
✓ Branch 2 taken 2240 times.
 4662 for (unsigned i = 0; i < GetNumTasks(); ++i) {
50
1/2
✓ Branch 2 taken 2422 times.
✗ Branch 3 not taken.
 2422 Tube<UploadJob> *t = new Tube<UploadJob>();
51 2422 tubes_upload_.TakeTube(t);
52
1/2
✓ Branch 2 taken 2422 times.
✗ Branch 3 not taken.
 2422 tasks_upload_.TakeConsumer(new TaskUpload(this, t));
53 }
54 2240 tubes_upload_.Activate();
55 2240 tasks_upload_.Spawn();
56 2240 return true;
57 }
58
59 539 bool AbstractUploader::FinalizeSession(bool /*commit*/,
60 const std::string & /*old_root_hash*/,
61 const std::string & /*new_root_hash*/,
62 const RepositoryTag & /*tag*/) {
63 539 return true;
64 }
65
66
67 1393 int AbstractUploader::CreateAndOpenTemporaryChunkFile(std::string *path) const {
68 const std::string tmp_path = CreateTempPath(
69
3/6
✓ Branch 1 taken 1393 times.
✗ Branch 2 not taken.
✓ Branch 4 taken 1393 times.
✗ Branch 5 not taken.
✓ Branch 7 taken 1393 times.
✗ Branch 8 not taken.
 2786 spooler_definition_.temporary_path + "/" + "chunk", 0644);
70
1/2
✗ Branch 1 not taken.
✓ Branch 2 taken 1393 times.
 1393 if (tmp_path.empty()) {
71 ✗ LogCvmfs(kLogSpooler, kLogStderr,
72 "Failed to create temp file in %s for upload of file chunk"
73 " (errno: %d).",
74 ✗ spooler_definition_.temporary_path.c_str(), errno);
75 ✗ return -1;
76 }
77
78
1/2
✓ Branch 2 taken 1393 times.
✗ Branch 3 not taken.
 1393 const int tmp_fd = open(tmp_path.c_str(), O_WRONLY);
79
1/2
✗ Branch 0 not taken.
✓ Branch 1 taken 1393 times.
 1393 if (tmp_fd < 0) {
80 ✗ LogCvmfs(kLogSpooler, kLogStderr,
81 "Failed to open temp file '%s' for upload of file chunk "
82 "(errno: %d)",
83 ✗ tmp_path.c_str(), errno);
84 ✗ unlink(tmp_path.c_str());
85 } else {
86
1/2
✓ Branch 1 taken 1393 times.
✗ Branch 2 not taken.
 1393 *path = tmp_path;
87 }
88
89 1393 return tmp_fd;
90 1393 }
91
92 2239 void AbstractUploader::TearDown() { tasks_upload_.Terminate(); }
93
94 2748 void AbstractUploader::WaitForUpload() const { jobs_in_flight_.WaitForZero(); }
95
96 30 void AbstractUploader::InitCounters(perf::StatisticsTemplate *statistics) {
97
2/4
✓ Branch 2 taken 30 times.
✗ Branch 3 not taken.
✓ Branch 5 taken 30 times.
✗ Branch 6 not taken.
 30 counters_ = std::unique_ptr<UploadCounters>(new UploadCounters(*statistics));
98 30 }
99
100 1400 void AbstractUploader::CountUploadedChunks() const {
101
1/2
✗ Branch 1 not taken.
✓ Branch 2 taken 1400 times.
 1400 if (counters_.get() != nullptr) {
102 ✗ perf::Inc(counters_->n_chunks_added);
103 }
104 1400 }
105
106 ✗ void AbstractUploader::DecUploadedChunks() const {
107 ✗ if (counters_.get() != nullptr) {
108 ✗ perf::Dec(counters_->n_chunks_added);
109 }
110 }
111
112 1400 void AbstractUploader::CountUploadedBytes(int64_t bytes_written) const {
113
1/2
✗ Branch 1 not taken.
✓ Branch 2 taken 1400 times.
 1400 if (counters_.get() != nullptr) {
114 ✗ perf::Xadd(counters_->sz_uploaded_bytes, bytes_written);
115 }
116 1400 }
117
118 ✗ void AbstractUploader::CountDuplicates() const {
119 ✗ if (counters_.get() != nullptr) {
120 ✗ perf::Inc(counters_->n_chunks_duplicated);
121 }
122 }
123
124 1191 void AbstractUploader::CountUploadedCatalogs() const {
125
2/2
✓ Branch 1 taken 30 times.
✓ Branch 2 taken 1161 times.
 1191 if (counters_.get() != nullptr) {
126 30 perf::Inc(counters_->n_catalogs_added);
127 }
128 1191 }
129
130 1191 void AbstractUploader::CountUploadedCatalogBytes(int64_t bytes_written) const {
131
2/2
✓ Branch 1 taken 30 times.
✓ Branch 2 taken 1161 times.
 1191 if (counters_.get() != nullptr) {
132 30 perf::Xadd(counters_->sz_uploaded_catalog_bytes, bytes_written);
133 }
134 1191 }
135
136 //------------------------------------------------------------------------------
137
138
139 8178062 void TaskUpload::Process(AbstractUploader::UploadJob *upload_job) {
140
2/3
✓ Branch 0 taken 5169573 times.
✓ Branch 1 taken 3008489 times.
✗ Branch 2 not taken.
 8178062 switch (upload_job->type) {
141 5169573 case AbstractUploader::UploadJob::Upload:
142 5169573 uploader_->StreamedUpload(upload_job->stream_handle, upload_job->buffer,
143 upload_job->callback);
144 5169575 break;
145
146 3008489 case AbstractUploader::UploadJob::Commit:
147 3008489 uploader_->FinalizeStreamedUpload(upload_job->stream_handle,
148 3008489 upload_job->content_hash);
149 3008489 break;
150
151 ✗ default:
152 ✗ PANIC(NULL);
153 }
154
155
1/2
✓ Branch 0 taken 8178064 times.
✗ Branch 1 not taken.
 8178064 delete upload_job;
156 8178064 }
157
158 } // namespace upload
159