GCC Code Coverage Report

Directory: cvmfs/
File: cvmfs/fetch.cc
Date: 2026-02-01 02:35:56
Exec Total Coverage
Lines: 155 157 98.7%
Branches: 101 173 58.4%
Line Branch Exec Source
1 /**
2 * This file is part of the CernVM File System.
3 */
4
5
6 #include "fetch.h"
7
8 #include <unistd.h>
9
10 #include "backoff.h"
11 #include "cache.h"
12 #include "clientctx.h"
13 #include "interrupt.h"
14 #include "network/download.h"
15 #include "quota.h"
16 #include "statistics.h"
17 #include "util/concurrency.h"
18 #include "util/logging.h"
19 #include "util/posix.h"
20
21 using namespace std; // NOLINT
22
23 namespace cvmfs {
24
25 74 void TLSDestructor(void *data) {
26 74 Fetcher::ThreadLocalStorage *tls = static_cast<Fetcher::ThreadLocalStorage *>(
27 data);
28 74 std::vector<Fetcher::ThreadLocalStorage *> *tls_blocks = &tls->fetcher
29 ->tls_blocks_;
30
31 {
32 74 const MutexLockGuard m(tls->fetcher->lock_tls_blocks_);
33 74 for (vector<Fetcher::ThreadLocalStorage *>::iterator
34 74 i = tls_blocks->begin(),
35 74 iEnd = tls_blocks->end();
36
1/2
✓ Branch 1 taken 148 times.
✗ Branch 2 not taken.
 148 i != iEnd;
37 74 ++i) {
38
2/2
✓ Branch 1 taken 74 times.
✓ Branch 2 taken 74 times.
 148 if ((*i) == tls) {
39
1/2
✓ Branch 2 taken 74 times.
✗ Branch 3 not taken.
 74 tls_blocks->erase(i);
40 74 break;
41 }
42 }
43 74 }
44 74 tls->fetcher->CleanupTls(tls);
45 74 }
46
47
48 /**
49 * Called when a thread exists, releases a ThreadLocalStorage object and
50 * removes the pointer to it from tls_blocks_.
51 */
52 832 void Fetcher::CleanupTls(ThreadLocalStorage *tls) {
53 832 ClosePipe(tls->pipe_wait);
54
1/2
✓ Branch 0 taken 832 times.
✗ Branch 1 not taken.
 832 delete tls;
55 832 }
56
57
58 /**
59 * Initialized thread-local storage if called the first time in a new thread.
60 */
61 1539 Fetcher::ThreadLocalStorage *Fetcher::GetTls() {
62 ThreadLocalStorage *tls = static_cast<ThreadLocalStorage *>(
63 1539 pthread_getspecific(thread_local_storage_));
64
2/2
✓ Branch 0 taken 707 times.
✓ Branch 1 taken 832 times.
 1539 if (tls != NULL)
65 707 return tls;
66
67
2/4
✓ Branch 1 taken 832 times.
✗ Branch 2 not taken.
✓ Branch 4 taken 832 times.
✗ Branch 5 not taken.
 832 tls = new ThreadLocalStorage();
68 832 tls->fetcher = this;
69
1/2
✓ Branch 1 taken 832 times.
✗ Branch 2 not taken.
 832 MakePipe(tls->pipe_wait);
70 832 tls->download_job.SetCompressed(true);
71 832 tls->download_job.SetProbeHosts(true);
72 832 const int retval = pthread_setspecific(thread_local_storage_, tls);
73
1/2
✗ Branch 0 not taken.
✓ Branch 1 taken 832 times.
 832 assert(retval == 0);
74
75 832 const MutexLockGuard m(lock_tls_blocks_);
76
1/2
✓ Branch 1 taken 832 times.
✗ Branch 2 not taken.
 832 tls_blocks_.push_back(tls);
77
78 832 return tls;
79 832 }
80
81
82 1762 int Fetcher::Fetch(const CacheManager::LabeledObject &object,
83 const std::string &alt_url) {
84 int fd_return; // Read-only file descriptor that is returned
85 int retval;
86
87 1762 perf::Inc(n_invocations);
88
89 // Try to open from local cache
90
3/4
✓ Branch 1 taken 1762 times.
✗ Branch 2 not taken.
✓ Branch 3 taken 593 times.
✓ Branch 4 taken 1169 times.
 1762 if ((fd_return = OpenSelect(object)) >= 0) {
91
1/2
✓ Branch 2 taken 593 times.
✗ Branch 3 not taken.
 593 LogCvmfs(kLogCache, kLogDebug, "hit: %s", object.label.path.c_str());
92 593 return fd_return;
93 }
94
95
1/2
✗ Branch 1 not taken.
✓ Branch 2 taken 1169 times.
 1169 if (object.id.IsNull()) {
96 // This has been seen when trying to load the root catalog signed by an
97 // invalid certificate on an empty cache
98 // TODO(jblomer): check if still necessary after the catalog reload refactor
99 ✗ LogCvmfs(kLogCache, kLogDebug, "cancel attempt to download null hash");
100 ✗ return -EIO;
101 }
102
103
1/2
✓ Branch 1 taken 1169 times.
✗ Branch 2 not taken.
 1169 ThreadLocalStorage *tls = GetTls();
104
105 // Synchronization point: either act as a master thread for this object or
106 // enqueue to the list of waiting threads.
107 1169 pthread_mutex_lock(lock_queues_download_);
108 1169 const ThreadQueues::iterator iDownloadQueue = queues_download_.find(
109
1/2
✓ Branch 1 taken 1169 times.
✗ Branch 2 not taken.
 1169 object.id);
110
2/2
✓ Branch 2 taken 37 times.
✓ Branch 3 taken 1132 times.
 1169 if (iDownloadQueue != queues_download_.end()) {
111
1/2
✓ Branch 2 taken 37 times.
✗ Branch 3 not taken.
 37 LogCvmfs(kLogCache, kLogDebug, "waiting for download of %s",
112 object.label.path.c_str());
113
114
1/2
✓ Branch 2 taken 37 times.
✗ Branch 3 not taken.
 37 iDownloadQueue->second->push_back(tls->pipe_wait[1]);
115 37 pthread_mutex_unlock(lock_queues_download_);
116
1/2
✓ Branch 1 taken 37 times.
✗ Branch 2 not taken.
 37 ReadPipe(tls->pipe_wait[0], &fd_return, sizeof(int));
117
118
1/2
✓ Branch 2 taken 37 times.
✗ Branch 3 not taken.
 37 LogCvmfs(kLogCache, kLogDebug, "received from another thread fd %d for %s",
119 fd_return, object.label.path.c_str());
120 37 return fd_return;
121 } else {
122 // Seems we are the first one, check again in the cache (race condition)
123
1/2
✓ Branch 1 taken 1132 times.
✗ Branch 2 not taken.
 1132 fd_return = OpenSelect(object);
124
2/2
✓ Branch 0 taken 37 times.
✓ Branch 1 taken 1095 times.
 1132 if (fd_return >= 0) {
125 37 pthread_mutex_unlock(lock_queues_download_);
126 37 return fd_return;
127 }
128
129 // Create a new queue for this chunk
130
1/2
✓ Branch 1 taken 1095 times.
✗ Branch 2 not taken.
 1095 queues_download_[object.id] = &tls->other_pipes_waiting;
131 1095 pthread_mutex_unlock(lock_queues_download_);
132 }
133
134 1095 perf::Inc(n_downloads);
135
136 // Involve the download manager
137
1/2
✓ Branch 2 taken 1095 times.
✗ Branch 3 not taken.
 1095 LogCvmfs(kLogCache, kLogDebug, "downloading %s", object.label.path.c_str());
138 1095 std::string url;
139
2/2
✓ Branch 1 taken 111 times.
✓ Branch 2 taken 984 times.
 1095 if (object.label.IsExternal()) {
140
2/4
✓ Branch 1 taken 111 times.
✗ Branch 2 not taken.
✓ Branch 4 taken 111 times.
✗ Branch 5 not taken.
 111 url = !alt_url.empty() ? alt_url : object.label.path;
141 } else {
142
8/14
✓ Branch 1 taken 37 times.
✓ Branch 2 taken 947 times.
✓ Branch 4 taken 37 times.
✗ Branch 5 not taken.
✓ Branch 7 taken 947 times.
✗ Branch 8 not taken.
✓ Branch 10 taken 947 times.
✗ Branch 11 not taken.
✓ Branch 13 taken 984 times.
✗ Branch 14 not taken.
✓ Branch 18 taken 947 times.
✓ Branch 19 taken 37 times.
✗ Branch 22 not taken.
✗ Branch 23 not taken.
 984 url = "/" + (alt_url.size() ? alt_url : "data/" + object.id.MakePath());
143 }
144
1/2
✓ Branch 1 taken 1095 times.
✗ Branch 2 not taken.
 1095 void *txn = alloca(cache_mgr_->SizeOfTxn());
145
1/2
✓ Branch 1 taken 1095 times.
✗ Branch 2 not taken.
 1095 retval = cache_mgr_->StartTxn(object.id, object.label.size, txn);
146
2/2
✓ Branch 0 taken 37 times.
✓ Branch 1 taken 1058 times.
 1095 if (retval < 0) {
147
1/2
✓ Branch 2 taken 37 times.
✗ Branch 3 not taken.
 37 LogCvmfs(kLogCache, kLogDebug, "could not start transaction on %s",
148 object.label.path.c_str());
149
1/2
✓ Branch 1 taken 37 times.
✗ Branch 2 not taken.
 37 SignalWaitingThreads(retval, object.id, tls);
150 37 return retval;
151 }
152
1/2
✓ Branch 1 taken 1058 times.
✗ Branch 2 not taken.
 1058 cache_mgr_->CtrlTxn(object.label, 0, txn);
153
154
1/2
✓ Branch 3 taken 1058 times.
✗ Branch 4 not taken.
 1058 LogCvmfs(kLogCache, kLogDebug, "miss: %s %s", object.label.path.c_str(),
155 url.c_str());
156 1058 TransactionSink sink(cache_mgr_, txn);
157 1058 tls->download_job.SetUrl(&url);
158 1058 tls->download_job.SetSink(&sink);
159 1058 tls->download_job.SetExpectedHash(&object.id);
160 1058 tls->download_job.SetExtraInfo(&object.label.path);
161
1/2
✓ Branch 1 taken 1058 times.
✗ Branch 2 not taken.
 1058 ClientCtx *ctx = ClientCtx::GetInstance();
162
3/4
✓ Branch 1 taken 1058 times.
✗ Branch 2 not taken.
✓ Branch 3 taken 4 times.
✓ Branch 4 taken 1054 times.
 1058 if (ctx->IsSet()) {
163
1/2
✓ Branch 5 taken 4 times.
✗ Branch 6 not taken.
 4 ctx->Get(tls->download_job.GetUidPtr(),
164 tls->download_job.GetGidPtr(),
165 tls->download_job.GetPidPtr(),
166 tls->download_job.GetInterruptCuePtr());
167 } else {
168 1054 *(tls->download_job.GetUidPtr()) = -1;
169 1054 *(tls->download_job.GetGidPtr()) = -1;
170 1054 *(tls->download_job.GetPidPtr()) = -1;
171 1054 *(tls->download_job.GetInterruptCuePtr()) = NULL;
172 }
173 1058 tls->download_job.SetCompressed(object.label.zip_algorithm
174 == zlib::kZlibDefault);
175 1058 tls->download_job.SetRangeOffset(object.label.range_offset);
176 1058 tls->download_job.SetRangeSize(static_cast<int64_t>(object.label.size));
177
1/2
✓ Branch 1 taken 1058 times.
✗ Branch 2 not taken.
 1058 download_mgr_->Fetch(&tls->download_job);
178
179
2/2
✓ Branch 1 taken 861 times.
✓ Branch 2 taken 197 times.
 1058 if (tls->download_job.error_code() == download::kFailOk) {
180
1/2
✓ Branch 2 taken 861 times.
✗ Branch 3 not taken.
 861 LogCvmfs(kLogCache, kLogDebug, "finished downloading of %s", url.c_str());
181
182
1/2
✓ Branch 1 taken 861 times.
✗ Branch 2 not taken.
 861 fd_return = cache_mgr_->OpenFromTxn(txn);
183
2/2
✓ Branch 0 taken 37 times.
✓ Branch 1 taken 824 times.
 861 if (fd_return < 0) {
184
1/2
✓ Branch 1 taken 37 times.
✗ Branch 2 not taken.
 37 cache_mgr_->AbortTxn(txn);
185
1/2
✓ Branch 1 taken 37 times.
✗ Branch 2 not taken.
 37 SignalWaitingThreads(fd_return, object.id, tls);
186 37 return fd_return;
187 }
188
189
1/2
✓ Branch 1 taken 824 times.
✗ Branch 2 not taken.
 824 retval = cache_mgr_->CommitTxn(txn);
190
2/2
✓ Branch 0 taken 74 times.
✓ Branch 1 taken 750 times.
 824 if (retval < 0) {
191
1/2
✓ Branch 1 taken 74 times.
✗ Branch 2 not taken.
 74 cache_mgr_->Close(fd_return);
192
1/2
✓ Branch 1 taken 74 times.
✗ Branch 2 not taken.
 74 SignalWaitingThreads(retval, object.id, tls);
193 74 return retval;
194 }
195
1/2
✓ Branch 1 taken 750 times.
✗ Branch 2 not taken.
 750 SignalWaitingThreads(fd_return, object.id, tls);
196 750 return fd_return;
197 }
198
199 // Download failed
200
1/5
✗ Branch 4 not taken.
✓ Branch 5 taken 197 times.
✗ Branch 6 not taken.
✗ Branch 9 not taken.
✗ Branch 10 not taken.
 394 LogCvmfs(kLogCache, kLogDebug | kLogSyslogErr,
201 "failed to fetch %s (hash: %s, error %d [%s])",
202
1/2
✓ Branch 1 taken 197 times.
✗ Branch 2 not taken.
 394 object.label.path.c_str(), object.id.ToString().c_str(),
203 197 tls->download_job.error_code(),
204 download::Code2Ascii(tls->download_job.error_code()));
205
1/2
✓ Branch 1 taken 197 times.
✗ Branch 2 not taken.
 197 cache_mgr_->AbortTxn(txn);
206
1/2
✓ Branch 1 taken 197 times.
✗ Branch 2 not taken.
 197 backoff_throttle_->Throttle();
207
1/2
✓ Branch 1 taken 197 times.
✗ Branch 2 not taken.
 197 SignalWaitingThreads(-EIO, object.id, tls);
208 197 return -EIO;
209 1095 }
210
211
212 2018 Fetcher::Fetcher(CacheManager *cache_mgr,
213 download::DownloadManager *download_mgr,
214 BackoffThrottle *backoff_throttle,
215 2018 perf::StatisticsTemplate statistics)
216 2018 : lock_queues_download_(NULL)
217 2018 , lock_tls_blocks_(NULL)
218 2018 , cache_mgr_(cache_mgr)
219 2018 , download_mgr_(download_mgr)
220 2018 , backoff_throttle_(backoff_throttle) {
221 int retval;
222 2018 retval = pthread_key_create(&thread_local_storage_, TLSDestructor);
223
1/2
✗ Branch 0 not taken.
✓ Branch 1 taken 2018 times.
 2018 assert(retval == 0);
224 2018 lock_queues_download_ = reinterpret_cast<pthread_mutex_t *>(
225 2018 smalloc(sizeof(pthread_mutex_t)));
226 2018 retval = pthread_mutex_init(lock_queues_download_, NULL);
227
1/2
✗ Branch 0 not taken.
✓ Branch 1 taken 2018 times.
 2018 assert(retval == 0);
228 2018 lock_tls_blocks_ = reinterpret_cast<pthread_mutex_t *>(
229 2018 smalloc(sizeof(pthread_mutex_t)));
230 2018 retval = pthread_mutex_init(lock_tls_blocks_, NULL);
231
1/2
✗ Branch 0 not taken.
✓ Branch 1 taken 2018 times.
 2018 assert(retval == 0);
232
3/6
✓ Branch 2 taken 2018 times.
✗ Branch 3 not taken.
✓ Branch 6 taken 2018 times.
✗ Branch 7 not taken.
✓ Branch 9 taken 2018 times.
✗ Branch 10 not taken.
 2018 n_downloads = statistics.RegisterTemplated(
233 "n_downloads",
234 "overall number of downloaded files (incl. catalogs, chunks)");
235
3/6
✓ Branch 2 taken 2018 times.
✗ Branch 3 not taken.
✓ Branch 6 taken 2018 times.
✗ Branch 7 not taken.
✓ Branch 9 taken 2018 times.
✗ Branch 10 not taken.
 2018 n_invocations = statistics.RegisterTemplated(
236 "n_invocations",
237 "overall number of object requests (incl. catalogs, chunks)");
238 2018 }
239
240
241 2018 Fetcher::~Fetcher() {
242 int retval;
243
244 {
245 2018 const MutexLockGuard m(lock_tls_blocks_);
246
2/2
✓ Branch 1 taken 758 times.
✓ Branch 2 taken 2018 times.
 2776 for (unsigned i = 0; i < tls_blocks_.size(); ++i)
247 758 CleanupTls(tls_blocks_[i]);
248 2018 }
249
250 2018 retval = pthread_mutex_destroy(lock_tls_blocks_);
251
1/2
✗ Branch 0 not taken.
✓ Branch 1 taken 2018 times.
 2018 assert(retval == 0);
252 2018 free(lock_tls_blocks_);
253
254 2018 retval = pthread_mutex_destroy(lock_queues_download_);
255
1/2
✗ Branch 0 not taken.
✓ Branch 1 taken 2018 times.
 2018 assert(retval == 0);
256 2018 free(lock_queues_download_);
257
258 2018 retval = pthread_key_delete(thread_local_storage_);
259
1/2
✗ Branch 0 not taken.
✓ Branch 1 taken 2018 times.
 2018 assert(retval == 0);
260 2018 }
261
262
263 /**
264 * Depending on the object type, uses either Open() or OpenPinned() from the
265 * cache manager
266 */
267 2894 int Fetcher::OpenSelect(const CacheManager::LabeledObject &object) {
268
5/6
✓ Branch 1 taken 981 times.
✓ Branch 2 taken 1913 times.
✗ Branch 4 not taken.
✓ Branch 5 taken 981 times.
✓ Branch 6 taken 1913 times.
✓ Branch 7 taken 981 times.
 2894 if (object.label.IsCatalog() || object.label.IsPinned()) {
269 1913 return cache_mgr_->OpenPinned(object);
270 } else {
271 981 return cache_mgr_->Open(object);
272 }
273 }
274
275
276 1206 void Fetcher::SignalWaitingThreads(const int fd,
277 const shash::Any &id,
278 ThreadLocalStorage *tls) {
279 1206 const MutexLockGuard m(lock_queues_download_);
280
2/2
✓ Branch 1 taken 148 times.
✓ Branch 2 taken 1206 times.
 1354 for (unsigned i = 0, s = tls->other_pipes_waiting.size(); i < s; ++i) {
281
3/4
✓ Branch 0 taken 111 times.
✓ Branch 1 taken 37 times.
✓ Branch 3 taken 111 times.
✗ Branch 4 not taken.
 148 int fd_dup = (fd >= 0) ? cache_mgr_->Dup(fd) : fd;
282
1/2
✓ Branch 2 taken 148 times.
✗ Branch 3 not taken.
 148 WritePipe(tls->other_pipes_waiting[i], &fd_dup, sizeof(int));
283 }
284 1206 tls->other_pipes_waiting.clear();
285
1/2
✓ Branch 1 taken 1206 times.
✗ Branch 2 not taken.
 1206 queues_download_.erase(id);
286 1206 }
287
288 } // namespace cvmfs
289