GCC Code Coverage Report


Directory: cvmfs/
File: cvmfs/path_filters/dirtab.cc
Date: 2026-10-18 02:40:11
Exec Total Coverage
Lines: 87 95 91.6%
Branches: 68 92 73.9%

Line Branch Exec Source
1 /**
2 * This file is part of the CernVM File System.
3 */
4
5 #include "dirtab.h"
6
7 #include <cassert>
8 #include <cerrno>
9 #include <cstdio>
10 #include <cstdlib>
11
12 #include "util/logging.h"
13 #include "util/posix.h"
14 #include "util/string.h"
15
16 namespace catalog {
17
18 2356 Dirtab::Dirtab() : valid_(true) { }
19
20
21 13 bool Dirtab::Open(const std::string &dirtab_path) {
22
1/2
✗ Branch 1 not taken.
✓ Branch 2 taken 13 times.
13 if (!FileExists(dirtab_path)) {
23 ✗ LogCvmfs(kLogCatalog, kLogStderr, "Cannot find dirtab at '%s'",
24 dirtab_path.c_str());
25 ✗ valid_ = false;
26 ✗ return valid_;
27 }
28
29 13 FILE *dirtab_file = fopen(dirtab_path.c_str(), "r");
30
1/2
✗ Branch 0 not taken.
✓ Branch 1 taken 13 times.
13 if (dirtab_file == NULL) {
31 ✗ LogCvmfs(kLogCatalog, kLogStderr,
32 "Cannot open dirtab for reading at '%s' "
33 "(errno: %d)",
34 ✗ dirtab_path.c_str(), errno);
35 ✗ valid_ = false;
36 ✗ return valid_;
37 }
38
39 13 valid_ = Parse(dirtab_file);
40 13 fclose(dirtab_file);
41 13 return valid_;
42 }
43
44 1422 bool Dirtab::Parse(const std::string &dirtab) {
45 1422 valid_ = true;
46 1422 off_t line_offset = 0;
47
2/2
✓ Branch 1 taken 4324 times.
✓ Branch 2 taken 1422 times.
5746 while (line_offset < static_cast<off_t>(dirtab.size())) {
48 8648 const std::string line = GetLineMem(dirtab.c_str() + line_offset,
49
1/2
✓ Branch 3 taken 4324 times.
✗ Branch 4 not taken.
4324 dirtab.size() - line_offset);
50 4324 line_offset += line.size() + 1; // +1 == skipped \n
51
3/4
✓ Branch 1 taken 4324 times.
✗ Branch 2 not taken.
✓ Branch 3 taken 66 times.
✓ Branch 4 taken 4258 times.
4324 if (!ParseLine(line)) {
52 66 valid_ = false;
53 }
54 4324 }
55
4/4
✓ Branch 0 taken 1356 times.
✓ Branch 1 taken 66 times.
✓ Branch 3 taken 1323 times.
✓ Branch 4 taken 33 times.
1422 valid_ = valid_ && CheckRuleValidity();
56 1422 return valid_;
57 }
58
59
60 26 bool Dirtab::Parse(FILE *dirtab_file) {
61 26 valid_ = true;
62 26 std::string line;
63
3/4
✓ Branch 1 taken 52 times.
✗ Branch 2 not taken.
✓ Branch 3 taken 26 times.
✓ Branch 4 taken 26 times.
52 while (GetLineFile(dirtab_file, &line)) {
64
2/4
✓ Branch 1 taken 26 times.
✗ Branch 2 not taken.
✗ Branch 3 not taken.
✓ Branch 4 taken 26 times.
26 if (!ParseLine(line)) {
65 ✗ valid_ = false;
66 }
67 }
68
3/6
✓ Branch 0 taken 26 times.
✗ Branch 1 not taken.
✓ Branch 3 taken 26 times.
✗ Branch 4 not taken.
✓ Branch 5 taken 26 times.
✗ Branch 6 not taken.
26 valid_ = valid_ && CheckRuleValidity();
69 26 return valid_;
70 26 }
71
72
73 4350 bool Dirtab::ParseLine(const std::string &line) {
74 // line parsing is done using std::string iterators. Each parsing method ex-
75 // pects an iterator and the end iterator. While parsing itr is constantly
76 // incremented to walk through the given .cvmfsdirtab line.
77 4350 std::string::const_iterator itr = line.begin();
78 4350 const std::string::const_iterator iend = line.end();
79 4350 bool negation = false;
80
81 // parse preamble
82 4350 SkipWhitespace(iend, &itr);
83
2/2
✓ Branch 1 taken 717 times.
✓ Branch 2 taken 3633 times.
4350 if (*itr == Dirtab::kCommentMarker) {
84 717 return true;
85
2/2
✓ Branch 1 taken 822 times.
✓ Branch 2 taken 2811 times.
3633 } else if (*itr == Dirtab::kNegationMarker) {
86 822 negation = true;
87 822 ++itr;
88 822 SkipWhitespace(iend, &itr);
89 }
90
91 // extract and parse pathspec
92
2/4
✓ Branch 2 taken 3633 times.
✗ Branch 3 not taken.
✓ Branch 5 taken 3633 times.
✗ Branch 6 not taken.
7266 const std::string pathspec_str(Trim(std::string(itr, iend)));
93
1/2
✓ Branch 1 taken 3633 times.
✗ Branch 2 not taken.
3633 return this->ParsePathspec(pathspec_str, negation);
94 3633 }
95
96 4106 bool Dirtab::ParsePathspec(const std::string &pathspec_str, bool negation) {
97
2/2
✓ Branch 1 taken 771 times.
✓ Branch 2 taken 3335 times.
4106 if (pathspec_str.empty()) {
98 771 return true;
99 }
100
1/2
✓ Branch 1 taken 3335 times.
✗ Branch 2 not taken.
3335 const Pathspec pathspec(pathspec_str);
101
102 // all generated Pathspecs need to be valid and positive rules must be
103 // absolute. Otherwise the .cvmfsdirtab is not valid.
104
8/8
✓ Branch 1 taken 3302 times.
✓ Branch 2 taken 33 times.
✓ Branch 3 taken 2513 times.
✓ Branch 4 taken 789 times.
✓ Branch 6 taken 33 times.
✓ Branch 7 taken 2480 times.
✓ Branch 8 taken 66 times.
✓ Branch 9 taken 3269 times.
3335 if (!pathspec.IsValid() || (!negation && !pathspec.IsAbsolute())) {
105 66 return false;
106 }
107
108 // create a new dirtab rule
109
1/2
✓ Branch 1 taken 3269 times.
✗ Branch 2 not taken.
3269 const Rule rule(pathspec, negation);
110
1/2
✓ Branch 1 taken 3269 times.
✗ Branch 2 not taken.
3269 AddRule(rule);
111 3269 return true;
112 3335 }
113
114
115 3269 void Dirtab::AddRule(const Rule &rule) {
116
2/2
✓ Branch 0 taken 789 times.
✓ Branch 1 taken 2480 times.
3269 if (rule.is_negation) {
117 789 negative_rules_.push_back(rule);
118 } else {
119 2480 positive_rules_.push_back(rule);
120 }
121 3269 }
122
123
124 1382 bool Dirtab::CheckRuleValidity() const {
125 // check if there are contradicting positive and negative rules
126 1382 Rules::const_iterator p = positive_rules_.begin();
127 1382 const Rules::const_iterator pend = positive_rules_.end();
128
2/2
✓ Branch 2 taken 2447 times.
✓ Branch 3 taken 1349 times.
3796 for (; p != pend; ++p) {
129
1/2
✗ Branch 1 not taken.
✓ Branch 2 taken 2447 times.
2447 assert(!p->is_negation);
130 2447 Rules::const_iterator n = negative_rules_.begin();
131 2447 const Rules::const_iterator nend = negative_rules_.end();
132
2/2
✓ Branch 2 taken 1431 times.
✓ Branch 3 taken 2414 times.
3845 for (; n != nend; ++n) {
133
1/2
✗ Branch 1 not taken.
✓ Branch 2 taken 1431 times.
1431 assert(n->is_negation);
134
3/4
✓ Branch 3 taken 1431 times.
✗ Branch 4 not taken.
✓ Branch 5 taken 33 times.
✓ Branch 6 taken 1398 times.
1431 if (p->pathspec == n->pathspec) {
135 33 return false;
136 }
137 }
138 }
139
140 1349 return true;
141 }
142
143
144 4062 bool Dirtab::IsMatching(const std::string &path) const {
145 // check if path has a positive match
146 4062 bool has_positive_match = false;
147 4062 Rules::const_iterator p = positive_rules_.begin();
148 4062 const Rules::const_iterator pend = positive_rules_.end();
149
2/2
✓ Branch 2 taken 8416 times.
✓ Branch 3 taken 2210 times.
10626 for (; p != pend; ++p) {
150
1/2
✗ Branch 1 not taken.
✓ Branch 2 taken 8416 times.
8416 assert(!p->is_negation);
151
3/4
✓ Branch 2 taken 8416 times.
✗ Branch 3 not taken.
✓ Branch 4 taken 1852 times.
✓ Branch 5 taken 6564 times.
8416 if (p->pathspec.IsMatching(path)) {
152 1852 has_positive_match = true;
153 1852 break;
154 }
155 }
156
157
5/6
✓ Branch 0 taken 1852 times.
✓ Branch 1 taken 2210 times.
✓ Branch 3 taken 1852 times.
✗ Branch 4 not taken.
✓ Branch 5 taken 1621 times.
✓ Branch 6 taken 231 times.
4062 return has_positive_match && !IsOpposing(path);
158 }
159
160
161 8350 bool Dirtab::IsOpposing(const std::string &path) const {
162 8350 Rules::const_iterator n = negative_rules_.begin();
163 8350 const Rules::const_iterator nend = negative_rules_.end();
164
2/2
✓ Branch 2 taken 6703 times.
✓ Branch 3 taken 7448 times.
14151 for (; n != nend; ++n) {
165
1/2
✗ Branch 1 not taken.
✓ Branch 2 taken 6703 times.
6703 assert(n->is_negation);
166
3/4
✓ Branch 2 taken 6703 times.
✗ Branch 3 not taken.
✓ Branch 4 taken 902 times.
✓ Branch 5 taken 5801 times.
6703 if (n->pathspec.IsMatchingRelaxed(path)) {
167 902 return true;
168 }
169 }
170
171 7448 return false;
172 }
173
174 } // namespace catalog
175