GCC Code Coverage Report

Directory: cvmfs/
File: cvmfs/path_filters/dirtab.cc
Date: 2026-01-11 02:35:46
Exec Total Coverage
Lines: 87 95 91.6%
Branches: 68 92 73.9%
Line Branch Exec Source
1 /**
2 * This file is part of the CernVM File System.
3 */
4
5 #include "dirtab.h"
6
7 #include <cassert>
8 #include <cerrno>
9 #include <cstdio>
10 #include <cstdlib>
11
12 #include "util/logging.h"
13 #include "util/posix.h"
14 #include "util/string.h"
15
16 namespace catalog {
17
18 762 Dirtab::Dirtab() : valid_(true) { }
19
20
21 23 bool Dirtab::Open(const std::string &dirtab_path) {
22
1/2
✗ Branch 1 not taken.
✓ Branch 2 taken 23 times.
 23 if (!FileExists(dirtab_path)) {
23 ✗ LogCvmfs(kLogCatalog, kLogStderr, "Cannot find dirtab at '%s'",
24 dirtab_path.c_str());
25 ✗ valid_ = false;
26 ✗ return valid_;
27 }
28
29 23 FILE *dirtab_file = fopen(dirtab_path.c_str(), "r");
30
1/2
✗ Branch 0 not taken.
✓ Branch 1 taken 23 times.
 23 if (dirtab_file == NULL) {
31 ✗ LogCvmfs(kLogCatalog, kLogStderr,
32 "Cannot open dirtab for reading at '%s' "
33 "(errno: %d)",
34 ✗ dirtab_path.c_str(), errno);
35 ✗ valid_ = false;
36 ✗ return valid_;
37 }
38
39 23 valid_ = Parse(dirtab_file);
40 23 fclose(dirtab_file);
41 23 return valid_;
42 }
43
44 670 bool Dirtab::Parse(const std::string &dirtab) {
45 670 valid_ = true;
46 670 off_t line_offset = 0;
47
2/2
✓ Branch 1 taken 3092 times.
✓ Branch 2 taken 670 times.
 3762 while (line_offset < static_cast<off_t>(dirtab.size())) {
48 6184 const std::string line = GetLineMem(dirtab.c_str() + line_offset,
49
1/2
✓ Branch 3 taken 3092 times.
✗ Branch 4 not taken.
 3092 dirtab.size() - line_offset);
50 3092 line_offset += line.size() + 1; // +1 == skipped \n
51
3/4
✓ Branch 1 taken 3092 times.
✗ Branch 2 not taken.
✓ Branch 3 taken 76 times.
✓ Branch 4 taken 3016 times.
 3092 if (!ParseLine(line)) {
52 76 valid_ = false;
53 }
54 3092 }
55
4/4
✓ Branch 0 taken 594 times.
✓ Branch 1 taken 76 times.
✓ Branch 3 taken 556 times.
✓ Branch 4 taken 38 times.
 670 valid_ = valid_ && CheckRuleValidity();
56 670 return valid_;
57 }
58
59
60 46 bool Dirtab::Parse(FILE *dirtab_file) {
61 46 valid_ = true;
62 46 std::string line;
63
3/4
✓ Branch 1 taken 92 times.
✗ Branch 2 not taken.
✓ Branch 3 taken 46 times.
✓ Branch 4 taken 46 times.
 92 while (GetLineFile(dirtab_file, &line)) {
64
2/4
✓ Branch 1 taken 46 times.
✗ Branch 2 not taken.
✗ Branch 3 not taken.
✓ Branch 4 taken 46 times.
 46 if (!ParseLine(line)) {
65 ✗ valid_ = false;
66 }
67 }
68
3/6
✓ Branch 0 taken 46 times.
✗ Branch 1 not taken.
✓ Branch 3 taken 46 times.
✗ Branch 4 not taken.
✓ Branch 5 taken 46 times.
✗ Branch 6 not taken.
 46 valid_ = valid_ && CheckRuleValidity();
69 46 return valid_;
70 46 }
71
72
73 3138 bool Dirtab::ParseLine(const std::string &line) {
74 // line parsing is done using std::string iterators. Each parsing method ex-
75 // pects an iterator and the end iterator. While parsing itr is constantly
76 // incremented to walk through the given .cvmfsdirtab line.
77 3138 std::string::const_iterator itr = line.begin();
78 3138 const std::string::const_iterator iend = line.end();
79 3138 bool negation = false;
80
81 // parse preamble
82 3138 SkipWhitespace(iend, &itr);
83
2/2
✓ Branch 1 taken 922 times.
✓ Branch 2 taken 2216 times.
 3138 if (*itr == Dirtab::kCommentMarker) {
84 922 return true;
85
2/2
✓ Branch 1 taken 914 times.
✓ Branch 2 taken 1302 times.
 2216 } else if (*itr == Dirtab::kNegationMarker) {
86 914 negation = true;
87 914 ++itr;
88 914 SkipWhitespace(iend, &itr);
89 }
90
91 // extract and parse pathspec
92
2/4
✓ Branch 2 taken 2216 times.
✗ Branch 3 not taken.
✓ Branch 5 taken 2216 times.
✗ Branch 6 not taken.
 4432 const std::string pathspec_str(Trim(std::string(itr, iend)));
93
1/2
✓ Branch 1 taken 2216 times.
✗ Branch 2 not taken.
 2216 return this->ParsePathspec(pathspec_str, negation);
94 2216 }
95
96 2446 bool Dirtab::ParsePathspec(const std::string &pathspec_str, bool negation) {
97
2/2
✓ Branch 1 taken 380 times.
✓ Branch 2 taken 2066 times.
 2446 if (pathspec_str.empty()) {
98 380 return true;
99 }
100
1/2
✓ Branch 1 taken 2066 times.
✗ Branch 2 not taken.
 2066 const Pathspec pathspec(pathspec_str);
101
102 // all generated Pathspecs need to be valid and positive rules must be
103 // absolute. Otherwise the .cvmfsdirtab is not valid.
104
8/8
✓ Branch 1 taken 2028 times.
✓ Branch 2 taken 38 times.
✓ Branch 3 taken 1152 times.
✓ Branch 4 taken 876 times.
✓ Branch 6 taken 38 times.
✓ Branch 7 taken 1114 times.
✓ Branch 8 taken 76 times.
✓ Branch 9 taken 1990 times.
 2066 if (!pathspec.IsValid() || (!negation && !pathspec.IsAbsolute())) {
105 76 return false;
106 }
107
108 // create a new dirtab rule
109
1/2
✓ Branch 1 taken 1990 times.
✗ Branch 2 not taken.
 1990 const Rule rule(pathspec, negation);
110
1/2
✓ Branch 1 taken 1990 times.
✗ Branch 2 not taken.
 1990 AddRule(rule);
111 1990 return true;
112 2066 }
113
114
115 1990 void Dirtab::AddRule(const Rule &rule) {
116
2/2
✓ Branch 0 taken 876 times.
✓ Branch 1 taken 1114 times.
 1990 if (rule.is_negation) {
117 876 negative_rules_.push_back(rule);
118 } else {
119 1114 positive_rules_.push_back(rule);
120 }
121 1990 }
122
123
124 640 bool Dirtab::CheckRuleValidity() const {
125 // check if there are contradicting positive and negative rules
126 640 Rules::const_iterator p = positive_rules_.begin();
127 640 const Rules::const_iterator pend = positive_rules_.end();
128
2/2
✓ Branch 2 taken 1076 times.
✓ Branch 3 taken 602 times.
 1678 for (; p != pend; ++p) {
129
1/2
✗ Branch 1 not taken.
✓ Branch 2 taken 1076 times.
 1076 assert(!p->is_negation);
130 1076 Rules::const_iterator n = negative_rules_.begin();
131 1076 const Rules::const_iterator nend = negative_rules_.end();
132
2/2
✓ Branch 2 taken 1655 times.
✓ Branch 3 taken 1038 times.
 2693 for (; n != nend; ++n) {
133
1/2
✗ Branch 1 not taken.
✓ Branch 2 taken 1655 times.
 1655 assert(n->is_negation);
134
3/4
✓ Branch 3 taken 1655 times.
✗ Branch 4 not taken.
✓ Branch 5 taken 38 times.
✓ Branch 6 taken 1617 times.
 1655 if (p->pathspec == n->pathspec) {
135 38 return false;
136 }
137 }
138 }
139
140 602 return true;
141 }
142
143
144 2419 bool Dirtab::IsMatching(const std::string &path) const {
145 // check if path has a positive match
146 2419 bool has_positive_match = false;
147 2419 Rules::const_iterator p = positive_rules_.begin();
148 2419 const Rules::const_iterator pend = positive_rules_.end();
149
2/2
✓ Branch 2 taken 4722 times.
✓ Branch 3 taken 1085 times.
 5807 for (; p != pend; ++p) {
150
1/2
✗ Branch 1 not taken.
✓ Branch 2 taken 4722 times.
 4722 assert(!p->is_negation);
151
3/4
✓ Branch 2 taken 4722 times.
✗ Branch 3 not taken.
✓ Branch 4 taken 1334 times.
✓ Branch 5 taken 3388 times.
 4722 if (p->pathspec.IsMatching(path)) {
152 1334 has_positive_match = true;
153 1334 break;
154 }
155 }
156
157
5/6
✓ Branch 0 taken 1334 times.
✓ Branch 1 taken 1085 times.
✓ Branch 3 taken 1334 times.
✗ Branch 4 not taken.
✓ Branch 5 taken 1068 times.
✓ Branch 6 taken 266 times.
 2419 return has_positive_match && !IsOpposing(path);
158 }
159
160
161 4437 bool Dirtab::IsOpposing(const std::string &path) const {
162 4437 Rules::const_iterator n = negative_rules_.begin();
163 4437 const Rules::const_iterator nend = negative_rules_.end();
164
2/2
✓ Branch 2 taken 7827 times.
✓ Branch 3 taken 3463 times.
 11290 for (; n != nend; ++n) {
165
1/2
✗ Branch 1 not taken.
✓ Branch 2 taken 7827 times.
 7827 assert(n->is_negation);
166
3/4
✓ Branch 2 taken 7827 times.
✗ Branch 3 not taken.
✓ Branch 4 taken 974 times.
✓ Branch 5 taken 6853 times.
 7827 if (n->pathspec.IsMatchingRelaxed(path)) {
167 974 return true;
168 }
169 }
170
171 3463 return false;
172 }
173
174 } // namespace catalog
175