GCC Code Coverage Report


Directory: cvmfs/
File: cvmfs/path_filters/dirtab.cc
Date: 2026-01-04 02:35:37
Exec Total Coverage
Lines: 87 95 91.6%
Branches: 68 92 73.9%

Line Branch Exec Source
1 /**
2 * This file is part of the CernVM File System.
3 */
4
5 #include "dirtab.h"
6
7 #include <cassert>
8 #include <cerrno>
9 #include <cstdio>
10 #include <cstdlib>
11
12 #include "util/logging.h"
13 #include "util/posix.h"
14 #include "util/string.h"
15
16 namespace catalog {
17
18 486 Dirtab::Dirtab() : valid_(true) { }
19
20
21 1 bool Dirtab::Open(const std::string &dirtab_path) {
22
1/2
✗ Branch 1 not taken.
✓ Branch 2 taken 1 times.
1 if (!FileExists(dirtab_path)) {
23 LogCvmfs(kLogCatalog, kLogStderr, "Cannot find dirtab at '%s'",
24 dirtab_path.c_str());
25 valid_ = false;
26 return valid_;
27 }
28
29 1 FILE *dirtab_file = fopen(dirtab_path.c_str(), "r");
30
1/2
✗ Branch 0 not taken.
✓ Branch 1 taken 1 times.
1 if (dirtab_file == NULL) {
31 LogCvmfs(kLogCatalog, kLogStderr,
32 "Cannot open dirtab for reading at '%s' "
33 "(errno: %d)",
34 dirtab_path.c_str(), errno);
35 valid_ = false;
36 return valid_;
37 }
38
39 1 valid_ = Parse(dirtab_file);
40 1 fclose(dirtab_file);
41 1 return valid_;
42 }
43
44 482 bool Dirtab::Parse(const std::string &dirtab) {
45 482 valid_ = true;
46 482 off_t line_offset = 0;
47
2/2
✓ Branch 1 taken 2140 times.
✓ Branch 2 taken 482 times.
2622 while (line_offset < static_cast<off_t>(dirtab.size())) {
48 4280 const std::string line = GetLineMem(dirtab.c_str() + line_offset,
49
1/2
✓ Branch 3 taken 2140 times.
✗ Branch 4 not taken.
2140 dirtab.size() - line_offset);
50 2140 line_offset += line.size() + 1; // +1 == skipped \n
51
3/4
✓ Branch 1 taken 2140 times.
✗ Branch 2 not taken.
✓ Branch 3 taken 68 times.
✓ Branch 4 taken 2072 times.
2140 if (!ParseLine(line)) {
52 68 valid_ = false;
53 }
54 2140 }
55
4/4
✓ Branch 0 taken 414 times.
✓ Branch 1 taken 68 times.
✓ Branch 3 taken 380 times.
✓ Branch 4 taken 34 times.
482 valid_ = valid_ && CheckRuleValidity();
56 482 return valid_;
57 }
58
59
60 2 bool Dirtab::Parse(FILE *dirtab_file) {
61 2 valid_ = true;
62 2 std::string line;
63
3/4
✓ Branch 1 taken 4 times.
✗ Branch 2 not taken.
✓ Branch 3 taken 2 times.
✓ Branch 4 taken 2 times.
4 while (GetLineFile(dirtab_file, &line)) {
64
2/4
✓ Branch 1 taken 2 times.
✗ Branch 2 not taken.
✗ Branch 3 not taken.
✓ Branch 4 taken 2 times.
2 if (!ParseLine(line)) {
65 valid_ = false;
66 }
67 }
68
3/6
✓ Branch 0 taken 2 times.
✗ Branch 1 not taken.
✓ Branch 3 taken 2 times.
✗ Branch 4 not taken.
✓ Branch 5 taken 2 times.
✗ Branch 6 not taken.
2 valid_ = valid_ && CheckRuleValidity();
69 2 return valid_;
70 2 }
71
72
73 2142 bool Dirtab::ParseLine(const std::string &line) {
74 // line parsing is done using std::string iterators. Each parsing method ex-
75 // pects an iterator and the end iterator. While parsing itr is constantly
76 // incremented to walk through the given .cvmfsdirtab line.
77 2142 std::string::const_iterator itr = line.begin();
78 2142 const std::string::const_iterator iend = line.end();
79 2142 bool negation = false;
80
81 // parse preamble
82 2142 SkipWhitespace(iend, &itr);
83
2/2
✓ Branch 1 taken 590 times.
✓ Branch 2 taken 1552 times.
2142 if (*itr == Dirtab::kCommentMarker) {
84 590 return true;
85
2/2
✓ Branch 1 taken 622 times.
✓ Branch 2 taken 930 times.
1552 } else if (*itr == Dirtab::kNegationMarker) {
86 622 negation = true;
87 622 ++itr;
88 622 SkipWhitespace(iend, &itr);
89 }
90
91 // extract and parse pathspec
92
2/4
✓ Branch 2 taken 1552 times.
✗ Branch 3 not taken.
✓ Branch 5 taken 1552 times.
✗ Branch 6 not taken.
3104 const std::string pathspec_str(Trim(std::string(itr, iend)));
93
1/2
✓ Branch 1 taken 1552 times.
✗ Branch 2 not taken.
1552 return this->ParsePathspec(pathspec_str, negation);
94 1552 }
95
96 1562 bool Dirtab::ParsePathspec(const std::string &pathspec_str, bool negation) {
97
2/2
✓ Branch 1 taken 340 times.
✓ Branch 2 taken 1222 times.
1562 if (pathspec_str.empty()) {
98 340 return true;
99 }
100
1/2
✓ Branch 1 taken 1222 times.
✗ Branch 2 not taken.
1222 const Pathspec pathspec(pathspec_str);
101
102 // all generated Pathspecs need to be valid and positive rules must be
103 // absolute. Otherwise the .cvmfsdirtab is not valid.
104
8/8
✓ Branch 1 taken 1188 times.
✓ Branch 2 taken 34 times.
✓ Branch 3 taken 600 times.
✓ Branch 4 taken 588 times.
✓ Branch 6 taken 34 times.
✓ Branch 7 taken 566 times.
✓ Branch 8 taken 68 times.
✓ Branch 9 taken 1154 times.
1222 if (!pathspec.IsValid() || (!negation && !pathspec.IsAbsolute())) {
105 68 return false;
106 }
107
108 // create a new dirtab rule
109
1/2
✓ Branch 1 taken 1154 times.
✗ Branch 2 not taken.
1154 const Rule rule(pathspec, negation);
110
1/2
✓ Branch 1 taken 1154 times.
✗ Branch 2 not taken.
1154 AddRule(rule);
111 1154 return true;
112 1222 }
113
114
115 1154 void Dirtab::AddRule(const Rule &rule) {
116
2/2
✓ Branch 0 taken 588 times.
✓ Branch 1 taken 566 times.
1154 if (rule.is_negation) {
117 588 negative_rules_.push_back(rule);
118 } else {
119 566 positive_rules_.push_back(rule);
120 }
121 1154 }
122
123
124 416 bool Dirtab::CheckRuleValidity() const {
125 // check if there are contradicting positive and negative rules
126 416 Rules::const_iterator p = positive_rules_.begin();
127 416 const Rules::const_iterator pend = positive_rules_.end();
128
2/2
✓ Branch 2 taken 532 times.
✓ Branch 3 taken 382 times.
914 for (; p != pend; ++p) {
129
1/2
✗ Branch 1 not taken.
✓ Branch 2 taken 532 times.
532 assert(!p->is_negation);
130 532 Rules::const_iterator n = negative_rules_.begin();
131 532 const Rules::const_iterator nend = negative_rules_.end();
132
2/2
✓ Branch 2 taken 913 times.
✓ Branch 3 taken 498 times.
1411 for (; n != nend; ++n) {
133
1/2
✗ Branch 1 not taken.
✓ Branch 2 taken 913 times.
913 assert(n->is_negation);
134
3/4
✓ Branch 3 taken 913 times.
✗ Branch 4 not taken.
✓ Branch 5 taken 34 times.
✓ Branch 6 taken 879 times.
913 if (p->pathspec == n->pathspec) {
135 34 return false;
136 }
137 }
138 }
139
140 382 return true;
141 }
142
143
144 1205 bool Dirtab::IsMatching(const std::string &path) const {
145 // check if path has a positive match
146 1205 bool has_positive_match = false;
147 1205 Rules::const_iterator p = positive_rules_.begin();
148 1205 const Rules::const_iterator pend = positive_rules_.end();
149
2/2
✓ Branch 2 taken 1758 times.
✓ Branch 3 taken 403 times.
2161 for (; p != pend; ++p) {
150
1/2
✗ Branch 1 not taken.
✓ Branch 2 taken 1758 times.
1758 assert(!p->is_negation);
151
3/4
✓ Branch 2 taken 1758 times.
✗ Branch 3 not taken.
✓ Branch 4 taken 802 times.
✓ Branch 5 taken 956 times.
1758 if (p->pathspec.IsMatching(path)) {
152 802 has_positive_match = true;
153 802 break;
154 }
155 }
156
157
5/6
✓ Branch 0 taken 802 times.
✓ Branch 1 taken 403 times.
✓ Branch 3 taken 802 times.
✗ Branch 4 not taken.
✓ Branch 5 taken 564 times.
✓ Branch 6 taken 238 times.
1205 return has_positive_match && !IsOpposing(path);
158 }
159
160
161 1875 bool Dirtab::IsOpposing(const std::string &path) const {
162 1875 Rules::const_iterator n = negative_rules_.begin();
163 1875 const Rules::const_iterator nend = negative_rules_.end();
164
2/2
✓ Branch 2 taken 4125 times.
✓ Branch 3 taken 1121 times.
5246 for (; n != nend; ++n) {
165
1/2
✗ Branch 1 not taken.
✓ Branch 2 taken 4125 times.
4125 assert(n->is_negation);
166
3/4
✓ Branch 2 taken 4125 times.
✗ Branch 3 not taken.
✓ Branch 4 taken 754 times.
✓ Branch 5 taken 3371 times.
4125 if (n->pathspec.IsMatchingRelaxed(path)) {
167 754 return true;
168 }
169 }
170
171 1121 return false;
172 }
173
174 } // namespace catalog
175