GCC Code Coverage Report


Directory: cvmfs/
File: cvmfs/path_filters/dirtab.cc
Date: 2026-03-01 02:36:14
Exec Total Coverage
Lines: 87 95 91.6%
Branches: 68 92 73.9%

Line Branch Exec Source
1 /**
2 * This file is part of the CernVM File System.
3 */
4
5 #include "dirtab.h"
6
7 #include <cassert>
8 #include <cerrno>
9 #include <cstdio>
10 #include <cstdlib>
11
12 #include "util/logging.h"
13 #include "util/posix.h"
14 #include "util/string.h"
15
16 namespace catalog {
17
18 38 Dirtab::Dirtab() : valid_(true) { }
19
20
21 1 bool Dirtab::Open(const std::string &dirtab_path) {
22
1/2
✗ Branch 1 not taken.
✓ Branch 2 taken 1 times.
1 if (!FileExists(dirtab_path)) {
23 LogCvmfs(kLogCatalog, kLogStderr, "Cannot find dirtab at '%s'",
24 dirtab_path.c_str());
25 valid_ = false;
26 return valid_;
27 }
28
29 1 FILE *dirtab_file = fopen(dirtab_path.c_str(), "r");
30
1/2
✗ Branch 0 not taken.
✓ Branch 1 taken 1 times.
1 if (dirtab_file == NULL) {
31 LogCvmfs(kLogCatalog, kLogStderr,
32 "Cannot open dirtab for reading at '%s' "
33 "(errno: %d)",
34 dirtab_path.c_str(), errno);
35 valid_ = false;
36 return valid_;
37 }
38
39 1 valid_ = Parse(dirtab_file);
40 1 fclose(dirtab_file);
41 1 return valid_;
42 }
43
44 34 bool Dirtab::Parse(const std::string &dirtab) {
45 34 valid_ = true;
46 34 off_t line_offset = 0;
47
2/2
✓ Branch 1 taken 156 times.
✓ Branch 2 taken 34 times.
190 while (line_offset < static_cast<off_t>(dirtab.size())) {
48 312 const std::string line = GetLineMem(dirtab.c_str() + line_offset,
49
1/2
✓ Branch 3 taken 156 times.
✗ Branch 4 not taken.
156 dirtab.size() - line_offset);
50 156 line_offset += line.size() + 1; // +1 == skipped \n
51
3/4
✓ Branch 1 taken 156 times.
✗ Branch 2 not taken.
✓ Branch 3 taken 4 times.
✓ Branch 4 taken 152 times.
156 if (!ParseLine(line)) {
52 4 valid_ = false;
53 }
54 156 }
55
4/4
✓ Branch 0 taken 30 times.
✓ Branch 1 taken 4 times.
✓ Branch 3 taken 28 times.
✓ Branch 4 taken 2 times.
34 valid_ = valid_ && CheckRuleValidity();
56 34 return valid_;
57 }
58
59
60 2 bool Dirtab::Parse(FILE *dirtab_file) {
61 2 valid_ = true;
62 2 std::string line;
63
3/4
✓ Branch 1 taken 4 times.
✗ Branch 2 not taken.
✓ Branch 3 taken 2 times.
✓ Branch 4 taken 2 times.
4 while (GetLineFile(dirtab_file, &line)) {
64
2/4
✓ Branch 1 taken 2 times.
✗ Branch 2 not taken.
✗ Branch 3 not taken.
✓ Branch 4 taken 2 times.
2 if (!ParseLine(line)) {
65 valid_ = false;
66 }
67 }
68
3/6
✓ Branch 0 taken 2 times.
✗ Branch 1 not taken.
✓ Branch 3 taken 2 times.
✗ Branch 4 not taken.
✓ Branch 5 taken 2 times.
✗ Branch 6 not taken.
2 valid_ = valid_ && CheckRuleValidity();
69 2 return valid_;
70 2 }
71
72
73 158 bool Dirtab::ParseLine(const std::string &line) {
74 // line parsing is done using std::string iterators. Each parsing method ex-
75 // pects an iterator and the end iterator. While parsing itr is constantly
76 // incremented to walk through the given .cvmfsdirtab line.
77 158 std::string::const_iterator itr = line.begin();
78 158 const std::string::const_iterator iend = line.end();
79 158 bool negation = false;
80
81 // parse preamble
82 158 SkipWhitespace(iend, &itr);
83
2/2
✓ Branch 1 taken 46 times.
✓ Branch 2 taken 112 times.
158 if (*itr == Dirtab::kCommentMarker) {
84 46 return true;
85
2/2
✓ Branch 1 taken 46 times.
✓ Branch 2 taken 66 times.
112 } else if (*itr == Dirtab::kNegationMarker) {
86 46 negation = true;
87 46 ++itr;
88 46 SkipWhitespace(iend, &itr);
89 }
90
91 // extract and parse pathspec
92
2/4
✓ Branch 2 taken 112 times.
✗ Branch 3 not taken.
✓ Branch 5 taken 112 times.
✗ Branch 6 not taken.
224 const std::string pathspec_str(Trim(std::string(itr, iend)));
93
1/2
✓ Branch 1 taken 112 times.
✗ Branch 2 not taken.
112 return this->ParsePathspec(pathspec_str, negation);
94 112 }
95
96 122 bool Dirtab::ParsePathspec(const std::string &pathspec_str, bool negation) {
97
2/2
✓ Branch 1 taken 20 times.
✓ Branch 2 taken 102 times.
122 if (pathspec_str.empty()) {
98 20 return true;
99 }
100
1/2
✓ Branch 1 taken 102 times.
✗ Branch 2 not taken.
102 const Pathspec pathspec(pathspec_str);
101
102 // all generated Pathspecs need to be valid and positive rules must be
103 // absolute. Otherwise the .cvmfsdirtab is not valid.
104
8/8
✓ Branch 1 taken 100 times.
✓ Branch 2 taken 2 times.
✓ Branch 3 taken 56 times.
✓ Branch 4 taken 44 times.
✓ Branch 6 taken 2 times.
✓ Branch 7 taken 54 times.
✓ Branch 8 taken 4 times.
✓ Branch 9 taken 98 times.
102 if (!pathspec.IsValid() || (!negation && !pathspec.IsAbsolute())) {
105 4 return false;
106 }
107
108 // create a new dirtab rule
109
1/2
✓ Branch 1 taken 98 times.
✗ Branch 2 not taken.
98 const Rule rule(pathspec, negation);
110
1/2
✓ Branch 1 taken 98 times.
✗ Branch 2 not taken.
98 AddRule(rule);
111 98 return true;
112 102 }
113
114
115 98 void Dirtab::AddRule(const Rule &rule) {
116
2/2
✓ Branch 0 taken 44 times.
✓ Branch 1 taken 54 times.
98 if (rule.is_negation) {
117 44 negative_rules_.push_back(rule);
118 } else {
119 54 positive_rules_.push_back(rule);
120 }
121 98 }
122
123
124 32 bool Dirtab::CheckRuleValidity() const {
125 // check if there are contradicting positive and negative rules
126 32 Rules::const_iterator p = positive_rules_.begin();
127 32 const Rules::const_iterator pend = positive_rules_.end();
128
2/2
✓ Branch 2 taken 52 times.
✓ Branch 3 taken 30 times.
82 for (; p != pend; ++p) {
129
1/2
✗ Branch 1 not taken.
✓ Branch 2 taken 52 times.
52 assert(!p->is_negation);
130 52 Rules::const_iterator n = negative_rules_.begin();
131 52 const Rules::const_iterator nend = negative_rules_.end();
132
2/2
✓ Branch 2 taken 81 times.
✓ Branch 3 taken 50 times.
131 for (; n != nend; ++n) {
133
1/2
✗ Branch 1 not taken.
✓ Branch 2 taken 81 times.
81 assert(n->is_negation);
134
3/4
✓ Branch 3 taken 81 times.
✗ Branch 4 not taken.
✓ Branch 5 taken 2 times.
✓ Branch 6 taken 79 times.
81 if (p->pathspec == n->pathspec) {
135 2 return false;
136 }
137 }
138 }
139
140 30 return true;
141 }
142
143
144 117 bool Dirtab::IsMatching(const std::string &path) const {
145 // check if path has a positive match
146 117 bool has_positive_match = false;
147 117 Rules::const_iterator p = positive_rules_.begin();
148 117 const Rules::const_iterator pend = positive_rules_.end();
149
2/2
✓ Branch 2 taken 222 times.
✓ Branch 3 taken 51 times.
273 for (; p != pend; ++p) {
150
1/2
✗ Branch 1 not taken.
✓ Branch 2 taken 222 times.
222 assert(!p->is_negation);
151
3/4
✓ Branch 2 taken 222 times.
✗ Branch 3 not taken.
✓ Branch 4 taken 66 times.
✓ Branch 5 taken 156 times.
222 if (p->pathspec.IsMatching(path)) {
152 66 has_positive_match = true;
153 66 break;
154 }
155 }
156
157
5/6
✓ Branch 0 taken 66 times.
✓ Branch 1 taken 51 times.
✓ Branch 3 taken 66 times.
✗ Branch 4 not taken.
✓ Branch 5 taken 52 times.
✓ Branch 6 taken 14 times.
117 return has_positive_match && !IsOpposing(path);
158 }
159
160
161 211 bool Dirtab::IsOpposing(const std::string &path) const {
162 211 Rules::const_iterator n = negative_rules_.begin();
163 211 const Rules::const_iterator nend = negative_rules_.end();
164
2/2
✓ Branch 2 taken 381 times.
✓ Branch 3 taken 161 times.
542 for (; n != nend; ++n) {
165
1/2
✗ Branch 1 not taken.
✓ Branch 2 taken 381 times.
381 assert(n->is_negation);
166
3/4
✓ Branch 2 taken 381 times.
✗ Branch 3 not taken.
✓ Branch 4 taken 50 times.
✓ Branch 5 taken 331 times.
381 if (n->pathspec.IsMatchingRelaxed(path)) {
167 50 return true;
168 }
169 }
170
171 161 return false;
172 }
173
174 } // namespace catalog
175